ruby-grape / ruby-grape/grape-roar
Does MultiJson.dump need to be passed env as well?
Open
Nobody has claimed this yet.
bug?
- Dominant language
- Ruby
- Stars
- 59
- Forks
- 14
- PR merge metrics
- No merged PRs in 30d
Description
In https://github.com/dblock/grape-roar/blob/master/lib/grape/roar/formatter.rb#L6, I think MultiJson.dump should also pass env as the second parameter.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read lib/grape/roar/formatter.rb at the referenced line and inspect how MultiJson.dump is currently called. Check the surrounding formatter behavior and existing tests, then verify that the requested env argument is passed correctly and that the formatter still behaves as expected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- api
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100