ruby-grape / ruby-grape/grape-entity

expose and method_missing

Open
#32 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug? question
Dominant language
Ruby
Stars
729
Forks
154
PR merge metrics
No merged PRs in 30d

Description

valid_exposure? uses respond_to?, and does not work with method_missing. Something like this would make it work

def respond_to_attribute?(object, attribute)
  object.send(attribute)
  true
rescue
  false
end

but it does seem dirty. Is it desired behavior to put the burden on exposed objects to properly respond to respond_to? or any interest in a pull request using this instead of respond_to??

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating valid_exposure? and tracing how it uses respond_to? for exposed objects. Reproduce the method_missing case, then establish the expected exposure behavior and add a regression test showing whether method_missing-backed attributes are recognized.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
api
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.