rubocop / rubocop/ruby-style-guide
NotImplementedError should be prefered for abstract definitions
Open
Nobody has claimed this yet.
- Dominant language
- No language data
- Stars
- 16.5k
- Forks
- 3.3k
- PR merge metrics
- No merged PRs in 30d
Description
This suggestion concerns this. The style guide gives good reasons to use fail, but I think that for abstract interfaces raise NotImplementedErrorshould be preferred way and mentioned on the style guide as well. This small discussion should be somewhat helpful also.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the fail method section of the Ruby style guide and review the linked Flay discussion for context. Determine how the guide should address abstract interfaces and NotImplementedError, then update the relevant guidance once the preferred wording is settled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100