Comments should be ignored for detecting commands boundaries
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 3.4k
- Forks
- 292
- PR merge metrics
- No merged PRs in 30d
Description
I have a SQL file that ends with a commented out line. SQL migration fails with the following error:
I0404 16:17:30.659541 22029 error.go:293] Error:INTERNAL ERROR: The last statement must be ended by a semicolon or '-- +migrate StatementEnd' marker.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the failure with a SQL migration file that ends in a commented-out line, then locate the command-boundary detection used by the migration parser. The fix is done when trailing comments no longer trigger the missing-semicolon or StatementEnd error, while genuine unterminated statements still do.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, sql
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100