rticommunity / rticommunity/rticonnextdds-examples
Include flags depending on the ConnextDDS version
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 148
- Forks
- 153
- PR merge metrics
- No merged PRs in 30d
Description
Information
- RTI Product: ConnextDDS Pro
- Version: 6.1.0
- Operating system: Linux
- Compiler: gcc
- Compiler version: 7.3.0
- Additional information:
What is the current behavior?
There are some examples (listed below) that add flags already included by FindRTIConnextDDS
File list
10 results - 10 filesexamples/connext_dds/dynamic_data_access_union_discriminator/c/CMakeLists.txt:
43 PROPERTIES
44: LINK_FLAGS -Wl,--no-as-needed)
45 endif()examples/connext_dds/dynamic_data_access_union_discriminator/c++/CMakeLists.txt:
43 PROPERTIES
44: LINK_FLAGS -Wl,--no-as-needed)
45 endif()examples/connext_dds/dynamic_data_access_union_discriminator/c++03/CMakeLists.txt:
38 PROPERTIES
39: LINK_FLAGS -Wl,--no-as-needed)
40 endif()examples/connext_dds/dynamic_data_access_union_discriminator/c++11/CMakeLists.txt:
38 PROPERTIES
39: LINK_FLAGS -Wl,--no-as-needed)
40 endif()examples/connext_dds/dynamic_data_nested_structs/c/CMakeLists.txt:
43 PROPERTIES
44: LINK_FLAGS -Wl,--no-as-needed)
45 endif()examples/connext_dds/dynamic_data_nested_structs/c++/CMakeLists.txt:
43 PROPERTIES
44: LINK_FLAGS -Wl,--no-as-needed)
45 endif()examples/connext_dds/dynamic_data_nested_structs/c++03/CMakeLists.txt:
43 PROPERTIES
44: LINK_FLAGS -Wl,--no-as-needed)
45 endif()examples/connext_dds/dynamic_data_sequences/c/CMakeLists.txt:
43 PROPERTIES
44: LINK_FLAGS -Wl,--no-as-needed)
45 endif()examples/connext_dds/dynamic_data_sequences/c++/CMakeLists.txt:
43 PROPERTIES
44: LINK_FLAGS -Wl,--no-as-needed)
45 endif()examples/connext_dds/dynamic_data_sequences/c++03/CMakeLists.txt:
43 PROPERTIES
44: LINK_FLAGS -Wl,--no-as-needed)
45 endif()
Suggested solutions
As the distributed logger component is included in the top-level CMakeLists.txt, we need to check whether the version is greater than 6.1.0, to filter them out. See comment
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the ten listed examples/*/CMakeLists.txt files and the top-level CMakeLists.txt, focusing on how the distributed logger component and FindRTIConnextDDS provide linker flags. Review the linked issue comment for the intended version check. Done means the examples no longer add flags already included for ConnextDDS versions greater than 6.1.0.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, cmake, cpp
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100