rsyslog / rsyslog/librelp

change API to use "const char" for strings that are actually constant

Open
#86 1 comment 0 reactions 1 assignee View on GitHub

@rgerhards is already working on this.

Since Apr 18, 2018.

Dominant language
C
Stars
32
Forks
39
Avg merge
2h 27m
Merged PRs (30d)
7

Description

Unfortunately the API did expose them as char. This is bad from a "clean compile" perspective, but may also convey the idea that these strings are actually modifiable. That is not the case, because it's almost constant string, and so any try to modify them can result in a segfault (depending on platform).

We need to check, though, if fixing this is causing severe trouble. If so, we need to re-evaluate.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.