rsyslog / rsyslog/libfastjson

subobj: use small keys without malloc

Open
#73 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
61
Forks
35
Avg merge
21m
Merged PRs (30d)
2

Description

We may use a 8-char (sizeof(Char*)) buffer to store small keys (via a union). However, we must think how we notice this was done. Most importantly, we should NOT copy constant keys - on the other hand: if the string is smaller, isn't that even better (also from a data spatial locality PoV).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the subobj representation and the code paths that store and copy keys; the issue names no files or tests. Establish how inline keys would be distinguished from constant or allocated keys, then define tests and completion criteria for avoiding malloc without changing key behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.