optimize _to_string functions
Open
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 61
- Forks
- 35
- Avg merge
- 21m
- Merged PRs (30d)
- 2
Description
as we have seen in https://github.com/rsyslog/libfastjson/issues/132, we can gain 10% performance "for free" by making sure that printbuf_memappend_no_nul can be inlined, that is is visible as a static function to the compile unit in question.
We should use a clean way to do that.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading issue #132 and locating the _to_string functions and printbuf_memappend_no_nul in libfastjson. Determine how the function is currently exposed across compilation units and identify a clean way to make it inline-visible. Done means the implementation preserves behavior and demonstrates the intended performance improvement.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- performance
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100