math_compat.h incorrectly tests declarations
Open
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 61
- Forks
- 35
- Avg merge
- 21m
- Merged PRs (30d)
- 2
Description
In 0.99.2 HAVE_DECL_* is set to zero or 1 by autoconf and the test in math_compat,h is for definition. Change these to:
# if !HAVE_DECL_INFINITY /\* for example */
# ....
rather than the existing #ifndef tests
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open math_compat.h and inspect the HAVE_DECL_* checks, starting with HAVE_DECL_INFINITY. Replace declaration checks that use #ifndef with tests of the macro value 0 or 1, as described in the issue. Verify that the compatibility header handles the autoconf values as intended.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100