rstudio / rstudio/shinytest2

Images are sensitive to system fonts

Open
#6 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
R
Stars
123
Forks
23
PR merge metrics
No merged PRs in 30d

Description

A common occurrence on GHA testing involves producing a plot from data.

In shinycoreci-apps, we have commonly seen plots adjust from bolded to unbolded text and points. There has been no logic change in Shiny/friends, only the virtual image has been updated.

Ex: The title changes from regular to bolded weight. This also has an effect on the bottom axis position.
https://github.com/rstudio/shinycoreci-apps/commit/bacf6764e8c7abbb82f98f3ffc3f72723f02a388?short_path=347b423#diff-347b423295ec899595d3e976a90d165ca9394fee95529e1344a3f2bca6a8cb80

Screen Shot 2021-09-28 at 2 32 42 PM

Goal: Make plot font consistent by not allowing default font weight to change.

Could this be done through systemfonts? Should it be done by fixing the virtual environment by the image version (Can this be done?)?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked shinycoreci-apps commit and the GitHub Actions image used for the affected plot. Investigate whether systemfonts or pinning the virtual environment controls the font weight; the issue is done when the plot font and layout remain consistent across image updates.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, r
Domain
ci-cd, testing-qa
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.