Reactive input private$currentThemeDependency is shown at the output

Open
#75 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript, r

Research direction

Run the provided R Shiny example with reactlog enabled and inspect the visualization that places nodes in input and output sections. Trace how private$currentThemeDependency is classified for display. Done means this input node appears in the input section rather than the output section.

Written by the indexing model from the issue text.

Description

With the changes from https://github.com/rstudio/shiny/pull/3116, a new input node private$currentThemeDependency is introduced which is expected as mentioned by @wch in https://github.com/rstudio/shiny/pull/3160.

However, this node is displayed at the output section instead of at the input section

Steps to reproduce:

  1. Run the following example
library(shiny)
# Enable reactlog
library(reactlog)
reactlog_enable()

ui <- fluidPage(
  titlePanel("Hello Shiny!"),
  sidebarLayout(
    sidebarPanel(
      sliderInput(inputId = "bins",
                  label = "Number of bins:",
                  min = 1,
                  max = 50,
                  value = 30)

    ),
    mainPanel(
      plotOutput(outputId = "distPlot")
    )
  ),
  ### start ui module
  reactlog_module_ui()
  ### end ui module
)

server <- function(input, output, session) {
  x <- faithful$waiting
  bins <- reactive({
    seq(min(x), max(x), length.out = input$bins + 1)
  })
  output$distPlot <- renderPlot({

    hist(x, breaks = bins(), col = "#75AADB", border = "white",
         xlab = "Waiting time to next eruption (in mins)",
         main = "Histogram of waiting times")

  })

  ### start server module
  reactlog_module_server()
  ### end server module
}

shinyApp(ui = ui, server = server)
  1. Notice that as highlighted in the snapshot below, private$currentThemeDependency despite being input value, its shown at the output section

shiny_private_current_theme-dependency_displayed at output

Dominant language
JavaScript
Stars
131
Forks
8
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from rstudio/reactlog

All issues in rstudio/reactlog

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.