Nodes should be grouped in "super nodes" that can expand and collapse

Open
#55 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript
Domain
data-visualization, frontend

Research direction

Start by locating the graph construction and rendering paths for renderPlot, deduper, and node_group. Trace how parent and child relationships are currently created, then define completion as grouped nodes that expand and collapse while preserving the specified outside parent and downstream child relationships.

Written by the indexing model from the issue text.

Description

Things like renderPlot should not create 5 nodes on the screen by default. Instead, it should be one super node that contains all 5 nodes.

Super nodes should:

  • Be able to expand and show contents
  • Be able to collapse to hide contents
  • Have any outside parent nodes be parents
  • Have any downstream children be children

In the case of a deduper where

deduper <- function(x, label) {
  res <- reactiveVal(x, label = label, node_group = "deduper")
  observe(label = "obs_x", node_group = "deduper", {
    res(x())
  })
  res
}
y <- deduper(x, label = "y")

where it would show graph

x -> deduper -> y -> etc

and not graph

x -> obs_x
y -> etc
Dominant language
JavaScript
Stars
131
Forks
8
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from rstudio/reactlog

All issues in rstudio/reactlog

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.