rstudio / rstudio/pointblank

Accomodate data.table sources including iDate type

Open
#353 1 comment 0 reactions 1 assignee View on GitHub

@rich-iannone is already working on this.

Since Sep 8, 2021.

Difficulty: [2] Intermediate Effort: [2] Medium Priority: ♨︎ Critical Type: ★ Enhancement
Dominant language
R
Stars
1k
Forks
59
Avg merge
25m
Merged PRs (30d)
4

Description

Prework

Proposal

Fantastic package! As requested in some other isues, I would like to validate my data in data.tables. Currently the draft_validation fails on the IDate type

R> DT <- data.table(date=as.Date(c("2016-05-26", "2016-04-20", "2016-06-01", "2015-06-05", "2015-06-05")),var=seq(1:5))
R> pointblank::draft_validation(DT,overwrite = T)
✓ The pointblank .R file has been written to `/home/cfljam/DT.R`
R> DT <- data.table(date=as.IDate(c("2016-05-26", "2016-04-20", "2016-06-01", "2015-06-05", "2015-06-05")),var=seq(1:5))
R> pointblank::draft_validation(DT,overwrite = T)
Error in if (column_role == "integer.discrete") { : 
  missing value where TRUE/FALSE needed

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.