rstudio / rstudio/platform-lib
Remove use of `fmt.Sprintf` of with `slog`
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 12
- Forks
- 0
- Avg merge
- 18h 8m
- Merged PRs (30d)
- 10
Description
Description
fmt.Sprintf() is used in combination with calls to the slog package. This is practice is discouraged when using slog. Instead non-static values to include in the log message should be passed to the logger as key value pairs. These uses of fmt.Sprint() and slog must be removed. pkg/rscache/file.go#280 for an instance of this improper usage.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with pkg/rscache/file.go around line 280, then search the repository for fmt.Sprintf or fmt.Sprint used with slog calls. Replace each identified logging use with structured key-value arguments, and verify that the improper combinations no longer remain.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100