rstudio / rstudio/pins-python

`.pin_upload` without `title` will say `title='...: a pinned str object'` for non-strings

Open
#346 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
59
Forks
11
PR merge metrics
No merged PRs in 30d

Description

This traces through to _pin_store where it replaces x with a string representation of the file path, so then when passed through to BaseBoard._create_meta on the line title = create_adaptor(x).default_title(name) where it creates the title based on the string type instead of the original x value.

I think a simple solution would just be to replace a title of None with create_adaptor(x).default_title(name) in the .pin_upload function, at a higher level.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Trace .pin_upload, _pin_store, and BaseBoard._create_meta, focusing on where a missing title is handled and where x is replaced by a path string. Confirm that non-string uploads without an explicit title derive the title from the original value rather than the string representation.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.