rstudio / rstudio/pins-python

Migrate to pre-commit.ci for pre-commit checks

Open
#255 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

.maint
Dominant language
Python
Stars
59
Forks
11
PR merge metrics
No merged PRs in 30d

Description

Currently the Code Checks workflow is emitting a few warnings.

One of them is the following:
Run pre-commit

The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-python@v4, pre-commit/action@v2.0.3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

The pre-commit/action README has the following message;
https://github.com/pre-commit/action

this action is in maintenance-only mode and will not be accepting new features.
generally you want to use pre-commit.ci which is faster and has more features.

I think we should consider performing the migration to pre-comit.ci.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the Code Checks workflow and the repository's current pre-commit setup, especially its use of pre-commit/action. Compare that setup with pre-commit.ci's documented integration and confirm how checks are triggered. Done means the migration is complete and the reported deprecated Node.js warnings no longer appear in the checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, python
Domain
ci-cd, tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.