rstudio / rstudio/packrat

load dependencies of external libraries from external lib

Open
#348 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
R
Stars
409
Forks
89
PR merge metrics
No merged PRs in 30d

Description

Hello,

When the option load.external.packages.on.startup is TRUE, packrat loads the dependent libraries from the private lib folder if they are there. I think it would be better to load them from the external lib as well.

It seems that they are loaded here:

 if (isTRUE(opts$load.external.packages.on.startup())) {
    lapply(opts$external.packages(), function(x) {
      library(x, character.only = TRUE, quietly = TRUE)
    })
  }

Then my suggestion is to replace this code with:

 if (isTRUE(opts$load.external.packages.on.startup())) {
    lapply(opts$external.packages(), function(x) {
      library(x, character.only = TRUE, quietly = TRUE, lib.loc=packrat:::libExtDir())
    })
  }

Or to use packrat::extlib.

It seems that there's the same "problem" with packrat::with_extlib.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in R/packrat-mode.R at the startup loading block linked in the issue, then inspect packrat::extlib and packrat::with_extlib to understand how external libraries are selected. Verify that dependencies of external packages load from the external library when load.external.packages.on.startup is TRUE, including the related with_extlib behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.