Use `load-balancing-enabled=1` in `rserver.conf` when enabling Load Balancing
Nobody has claimed this yet.
- Dominant language
- Markdown
- Stars
- 46
- Forks
- 40
- Avg merge
- 4h 3m
- Merged PRs (30d)
- 6
Description
Description
Noticed this log in a customer's log that was using our helm chart
[rserver] WARNING Found /mnt/load-balancer/rstudio/load-balancer - load balancing enabled for compatibility with 2023.06. Add: load-balancing-enabled=1 or 0 to rserver.conf to explicitly enable load balancing to remove this warning.; LOGGED FROM: bool rstudio::server::load_balancer::isLoadBalanced() src/cpp/server/load_balancer/LoadBalancer.cpp:819
This is a warning and can be ignored, but to lower the noise and reduce the fallout that will happen if the legacy-supporting code in Workbench is removed we should include the load-balancing-enabled=1 flag in rserver.conf whenever replicas > 0.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the Helm chart templates that generate rserver.conf and inspect how the replicas value is handled. When replicas is greater than zero, include load-balancing-enabled=1 in rserver.conf; verify the rendered chart output for that configuration and ensure the warning's requested setting is present.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- helm
- Domain
- devops
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100