rstudio / rstudio/helm

Remove `notebooks-enabled=1` from `jupyter.conf`

Open
#610 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

team: workbench
Dominant language
Markdown
Stars
46
Forks
40
Avg merge
4h 3m
Merged PRs (30d)
6

Description

In the 2024.09.0 Workbench release notes, Jupyter Hub support is being removed, by default:

Added support for Jupyter Notebook 7. (rstudio-pro#6266)
Replaced code server binary with PWB Code Server. PWB Code Server is bundled with the PWB VS Code Extension, so a separate install is no longer required. It is a fork of VS Code 1.93.0. (rstudio-pro#6265)
In VS Code sessions, Workbench now preserves the open directory or workspace on a per-session basis. (rstudio-pro#6491)
Fixed an issue preventing potential data leakage between users in the same browser session. (vscode-server#17)
Disabled Jupyter Notebooks by default on fresh installs of PWB. (rstudio-pro#6269)

Correspondingly, the product default for notebooks-enabled is 0 - docs

Accordingly, I'd propose updating the values in the helm charts to align: https://github.com/search?q=repo%3Arstudio%2Fhelm%20notebooks-enabled&type=code

Impact: We had removed our setting for notebooks-enabled to leverage the default of 0; but, it was still unexpectedly being set to 1, since we're leveraging Posit's Helm charts as a starting point.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the Helm repository for notebooks-enabled and inspect the chart values and templates that set it to 1. Align those chart defaults with the documented product default of 0, then verify that rendered chart configuration no longer enables Jupyter Notebooks by default.

Written by the indexing model from the issue text.

Assessment

Tech stack
helm
Domain
devops
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.