rstudio / rstudio/helm

Create sets of values files that pass install tests with the chart testing tool

Open
#585 0 comments 0 reactions 1 assignee View on GitHub

@jforest is already working on this.

Since Oct 16, 2024.

Dominant language
Markdown
Stars
46
Forks
40
Avg merge
4h 3m
Merged PRs (30d)
6

Description

EDIT: David Kegley added a step to run helm unittesting in the GHA. We will use these install tests and also use those unittests

Looking at this comment from David Kegley:

That makes sense, seems like we have the install half but are missing the assertions. I believe we just need to write some tests that live in the charts/rstudio-connect/templates/test directory and it sounds like they will get evaluated automatically by each ct install

https://helm.sh/docs/topics/chart_tests/
https://github.com/helm/chart-testing/blob/main/doc/ct_install.md#synopsis

I will explore if we can get some assertions set. EDIT: David already submitted and merged a PR to run helm unittest on the charts

The test suite does run by default: https://github.com/rstudio/helm/actions/runs/11560585710/job/32177753331#step:13:606 is an example. We only have that one single test in all the helm charts so far EDIT: Removed that one test as unneeded since the install tests do the same thing

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.