rstudio / rstudio/helm

Clean up graphite exporter definition

Open
#47 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

team: workbench
Dominant language
Markdown
Stars
46
Forks
40
Avg merge
4h 3m
Merged PRs (30d)
6

Description

Connected to #46

We fixed a small bug in host name detection (excluding dashes). However, we should harden this a bit:

  • Make sure that Connect has the same flexibility to customize mappingYaml with values
  • (probably unnecessary) pull into a library helper
  • Figure out what characters are actually allowed in docker / kubernetes / helm as hostnames, so we can be sure that our regex captures all of them

It's also possible that the product will beat us to actually expose prometheus metrics and save us some work 😄

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the graphite exporter definition and the connected #46 issue, then trace how Connect customizes mappingYaml. Confirm the allowed hostname characters for Docker, Kubernetes, and Helm and decide whether the logic belongs in a shared helper. Done means both customization paths are covered and the hostname matching behavior is verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, helm, kubernetes
Domain
devops, infrastructure
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.