rstudio-connect: consider allowing users to set launcher.DataDir instead of config.Launcher.DataDir
Nobody has claimed this yet.
- Dominant language
- Markdown
- Stars
- 46
- Forks
- 40
- Avg merge
- 4h 3m
- Merged PRs (30d)
- 6
Description
Some feedback we received during our user testing is that it is not always clear which configurations are required when launcher.enabled = true. For example, config.Launcher.DataDir must be set when launcher is enabled. Since there is already a precedent of modifying config.Launcher based on the value of launcher.enabled, would we also consider allowing users to set a DataDir under the launcher configuration in lieu of setting config.Launcher.DataDir. This would keep our launcher-related configs in one place and hopefully avoid some of that confusion.
We might also consider adding a check for if launcher.enabled, then launcher.DataDir must be defined. This leads to a connect startup error, but we could check for this in the chart instead.
Error: Launcher.ConnectDir and Launcher.DataDir must be configured to use Kubernetes.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how launcher.enabled and config.Launcher.DataDir are represented in the Helm chart values and rendered configuration. Determine how a launcher-local DataDir should map to the existing Launcher.DataDir, then verify that enabling the launcher without a required directory produces a clear chart or startup error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- helm, kubernetes
- Domain
- devops, infrastructure
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100