rstudio / rstudio/helm

[rstudio-connect] wrong type for var

Open
#409 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

team: connect team: package manager
Dominant language
Markdown
Stars
46
Forks
40
Avg merge
4h 3m
Merged PRs (30d)
6

Description

.Values.sharedStorage.storageClassName has the type bool and default false.

https://github.com/rstudio/helm/blob/666e86da88124a40e823a9e23925702d151b8076/charts/rstudio-connect/README.md?plain=1#L178

However, it's passed to the PersistentVolumeClaim kind, spec.storageClassName, which is a string.

https://github.com/rstudio/helm/blob/666e86da88124a40e823a9e23925702d151b8076/charts/rstudio-connect/templates/pvc.yaml#L14C3-L14C19

I haven't tested it, but based on the API reference this is probably a bug.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with charts/rstudio-connect/README.md around the sharedStorage.storageClassName entry and charts/rstudio-connect/templates/pvc.yaml around the PersistentVolumeClaim spec.storageClassName field. Check the chart value against the Kubernetes PersistentVolumeClaim API reference and render or validate the chart. Done means the value's documented/default type is compatible with the rendered field.

Written by the indexing model from the issue text.

Assessment

Tech stack
helm, kubernetes, yaml
Domain
infrastructure
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.