rstudio / rstudio/helm

Determine desired licensing behavior and ensure consistency across charts

Open
#239 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

consistency
Dominant language
Markdown
Stars
46
Forks
40
Avg merge
4h 3m
Merged PRs (30d)
6

Description

What is the desired license behavior for our charts?

i.e. if a license variable is not defined, should the chart send a warning in NOTES.txt? Should it fail?

On the RSC chart, if you do not specify a license (or specify an empty license by accident - i.e. if an env var is not defined or is empty), we just deploy the chart happily and the container never has a happy readinessProbe. You have to port-forward or curl the health check / etc. in order to figure out why it is unhappy. At very least, this seems less than ideal.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the RSC chart behavior when the license variable is undefined or empty, including the resulting NOTES.txt output and readinessProbe state. Compare that behavior with the other charts, then define the desired consistent response and document what should happen when a license is missing.

Written by the indexing model from the issue text.

Assessment

Tech stack
helm
Domain
devops
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.