rstudio / rstudio/helm

Make `launcher-mounts` append instead of replace

Open
#162 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

team: workbench
Dominant language
Markdown
Stars
46
Forks
40
Avg merge
4h 3m
Merged PRs (30d)
6

Description

The launcher-mounts helper currently only takes effect if no launcher-mounts are defined. It is not so difficult to append... we should probably just do that for better consistency / less surprise!

Possible BREAKING change for those with more than one entry... although we could also possibly catch such an issue and avoid breaking in that scenario.

At the same time:

  • consider supporting subpath stuff...
  • what if someone did not want to use our definition...?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the launcher-mounts helper and the existing launcher-mounts definitions in the Helm resources. Determine how multiple definitions are currently handled, then clarify the intended behavior for appending, subpaths, and users who want to opt out; done means the behavior is specified and verified without an unintended breaking change.

Written by the indexing model from the issue text.

Assessment

Tech stack
helm
Domain
devops
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.