rstudio / rstudio/flexdashboard

incorrect `DT::datatable()` rendering with "Scroller" extension

Open
#415 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
848
Forks
298
PR merge metrics
No merged PRs in 30d

Description

In flexdashboard-0.5.2 shiny::fillCol(flex=NA,...) rendered correct DT::datatable(..., extensions="Scroller",...). But since flexdashboard-0.6.0 this rendering is failed.

flexdasboard version 0.5.2:
version052

flexdasboard version 0.6.1:
version061

---
pagetitle: Scroller extension
runtime: shiny
output:
   flexdashboard::flex_dashboard:
      orientation: rows
---

```{r echo=TRUE}
'dummyTable' <- function() {
   DT::datatable(mtcars[,1:6],rownames=TRUE,extensions="Scroller"
                ,options=list(dom="ift",scroller=T
                             ,scrollY="calc(100vh - 400px)"))
}
```

# Incorrect table rendering and "Showing X to Y of Z entries" output. `flexdashboard` version is `r packageVersion("flexdashboard")`. `DT` version is `r packageVersion("DT")`.

## 

###

```{r echo=exists("fillCol"), eval=exists("fillCol")}
shiny::fillCol(flex=NA,DT::renderDT(dummyTable()))
```

###

```{r echo=TRUE}
dummyTable()
```

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the supplied flexdashboard document using shiny::fillCol() and DT::datatable() with the Scroller extension, then compare rendering between flexdashboard 0.5.2 and 0.6.1. Trace the rendering path for the fillCol entry point and verify the table no longer shows incorrect sizing or the extra "Showing X to Y of Z entries" output.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.