rstudio / rstudio/flexdashboard

Comments below valueboxes do not display as expected

Open
#253 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
848
Forks
298
PR merge metrics
No merged PRs in 30d

Description

When adding a comment below a valuebox, the text is absorbed into the valuebox itself. When the comment is above the chart it is wrapped in <blockquote> but it behaves differently below charts, especially for valueboxes. Perhaps I am missing something?

Working from a basic template:

---
title: "Untitled"
output: 
  flexdashboard::flex_dashboard:
    orientation: columns
    vertical_layout: fill
---

```{r setup, include=FALSE}
library(flexdashboard)
```

Column {data-width=650}
-----------------------------------------------------------------------

>Comment ABOVE

### valuebox1Infectious

```{r}
flexdashboard::valueBox(1000000, caption = 'Cool caption', icon = 'fas fa-calendar-alt')
```

> Comment BELOW

Column {data-width=350}
-----------------------------------------------------------------------

### Chart B

```{r}
plot(mtcars$cyl)
```

This produces:

image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the basic flexdashboard template in the issue and compare how the above-chart and below-chart comments render around the valueBox. Reproduce the behavior, then trace the valuebox and comment rendering paths. Done means a comment below a valuebox is displayed outside the valuebox with the expected blockquote behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
frontend, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.