Fillable Hidden Tabset Panel
Nobody has claimed this yet.
- Dominant language
- SCSS
- Stars
- 569
- Forks
- 72
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 5
Description
Hi, I am just trying out a fillable layouts and noticed that there is no support for fillability within navset_hidden. I see that it is based on tabsetPanel as opposed to navset_bar that supports fillability and uses an internal function.
I looked at the source code and noticed an unexported makeTabsFillable function. With it I was able to make myself a fillable hidden tabset panel:
fillable_hidden_tabset_panel <- function(..., id) {
panel <- shiny::tabsetPanel(id = id, type = "hidden", ...)
panel$children[[2]] <- bslib:::makeTabsFillable(panel$children[[2]])
bslib::as_fill_carrier(panel)
}
Do you think this is something that {bslib} could support out of the box?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the navset_hidden tabsetPanel path with navset_bar's existing fillability support, then inspect the unexported makeTabsFillable function and the as_fill_carrier workaround shown in the issue. Done means navset_hidden supports fillability out of the box without the custom wrapper.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- r
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100