rstudio / rstudio/bslib

`htmltools` in version 0.5.7 makes footer hide in `bslib`

Open
#900 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
SCSS
Stars
569
Forks
72
Avg merge
1d 2h
Merged PRs (30d)
5

Description

Code:

library(shiny)
library(bslib)
ui <- page_navbar(
  nav_panel("One",
            card(min_height = "100vh"),
            ),
  footer = tags$p("TEST")
)

server <- function(input, output, session) {
}

shinyApp(ui, server)

Problem: Footer (with the "TEST" string) is hide by card, in the previous htmltools version, it was stick on the bottom of webpage.

Info:

R version 4.3.2 (2023-10-31 ucrt)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows 10 x64 (build 19045)

Matrix products: default


locale:
[1] LC_COLLATE=Polish_Poland.utf8 
[2] LC_CTYPE=Polish_Poland.utf8   
[3] LC_MONETARY=Polish_Poland.utf8
[4] LC_NUMERIC=C                  
[5] LC_TIME=Polish_Poland.utf8    

time zone: Europe/Warsaw
tzcode source: internal

attached base packages:
[1] stats     graphics  grDevices utils    
[5] datasets  methods   base     

other attached packages:
[1] bslib_0.5.1   shiny_1.7.5.1

loaded via a namespace (and not attached):
 [1] digest_0.6.33   later_1.3.1    
 [3] R6_2.5.1        httpuv_1.6.12  
 [5] fastmap_1.1.1   magrittr_2.0.3 
 [7] cachem_1.0.8    memoise_2.0.1  
 [9] htmltools_0.5.7 lifecycle_1.0.4
[11] promises_1.2.1  cli_3.6.1      
[13] xtable_1.8-4    sass_0.4.7     
[15] jquerylib_0.1.4 withr_2.5.2    
[17] compiler_4.3.2  tools_4.3.2    
[19] mime_0.12       ellipsis_0.3.2 
[21] Rcpp_1.0.11     fs_1.6.3       
[23] jsonlite_1.8.7  rlang_1.1.2    

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Run the provided Shiny app with htmltools 0.5.7 and compare it with the previous htmltools version to reproduce the footer behavior. Trace the bslib page_navbar, card, and footer styling involved in the layout. Done means the TEST footer remains visible at the bottom while the card uses min_height = "100vh".

Written by the indexing model from the issue text.

Assessment

Tech stack
bootstrap, r, sass, scss
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.