rstudio / rstudio/bslib

Use `_` rather than `-` to create ID values

Open
#877 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
SCSS
Stars
569
Forks
72
Avg merge
1d 2h
Merged PRs (30d)
5

Description

Good to avoid any possible mix up with a module.

Ex: Placeholder id within accordion().

(Found while trying to resolve the placeholder ID and - chars were not allowed.)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the accordion entry point and search the implementation for where placeholder ID values are generated. Confirm the current hyphenated value and determine the affected examples or tests; the work is done when placeholder IDs use underscores and remain valid without confusing them with module names.

Written by the indexing model from the issue text.

Assessment

Tech stack
bootstrap, sass
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.