rstudio / rstudio/bslib

Revisit nav-link alignment with navbar

Open
#856 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
SCSS
Stars
569
Forks
72
Avg merge
1d 2h
Merged PRs (30d)
5

Description

From shinycoreci/inst/apps/308-sidebar-kitchen-sink:

Screenshot 2023-10-20 at 11 44 14 AM

I'm not sure the negative margin approach used in #847 is the best, most robust way to get the alignment the way we want it

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in shinycoreci/inst/apps/308-sidebar-kitchen-sink and review the negative-margin approach introduced in #847 alongside the attached screenshot. Determine a more robust way to align the nav links with the navbar, then verify the kitchen-sink app shows the intended alignment without relying on the questioned approach.

Written by the indexing model from the issue text.

Assessment

Tech stack
bootstrap, scss
Domain
design, frontend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.