rstudio / rstudio/bslib

`sidebar()` in `page_navbar()` adds gaps/padding

Open
#761 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
SCSS
Stars
569
Forks
72
Avg merge
1d 2h
Merged PRs (30d)
5

Description

Describe the problem

Adding a sidebar() to page_navbar() seems to add back (? or ignore?) the gap removals. In comparison, this seems to work (or work as I expect it) with layout_sidebar().

library(bslib)
make_page <- function(sidebar = NULL) {
  page_navbar(
    title = "navbar title",
    sidebar = sidebar,
    gap = 0,
    padding = 0,
    nav_panel(
      title = "panel title", 
      navset_card_tab(
        title = "title", 
        nav_panel("title", card("hello"))
      )
    )
  )
}

make_page()
make_page(sidebar(open = FALSE))

# compared to...
layout_sidebar(
  title = "title",
  sidebar = sidebar(),
  card(card_header("header"), "body"),
  gap = 0,
  padding = 0
)
make_page()

image

make_page(sidebar(open = FALSE))

image

compared to ...

image

Session Info

─ Session info ─────────────────────────────────────────────────────────────
 setting  value
 version  R version 4.3.1 (2023-06-16)
 os       Ubuntu 22.04.3 LTS
 system   x86_64, linux-gnu
 ui       X11
 language (EN)
 collate  en_US.UTF-8
 ctype    en_US.UTF-8
 tz       America/New_York
 date     2023-08-23
 pandoc   2.9.2.1 @ /usr/bin/pandoc

─ Packages ─────────────────────────────────────────────────────────────────

package     * version    date (UTC) lib source

bsicons       0.1.1      2023-08-11 [1] CRAN (R 4.3.1)

bslib       * 0.5.1.9000 2023-08-23 [1] Github (rstudio/bslib@a4e487c)

cachem        1.0.8      2023-05-01 [1] CRAN (R 4.3.1)

callr         3.7.3      2022-11-02 [1] CRAN (R 4.3.1)

cli           3.6.1      2023-03-23 [1] CRAN (R 4.3.1)

crayon        1.5.2      2022-09-29 [1] CRAN (R 4.3.1)

devtools      2.4.5      2022-10-11 [1] CRAN (R 4.3.1)

digest        0.6.33     2023-07-07 [1] CRAN (R 4.3.1)

ellipsis      0.3.2      2021-04-29 [1] CRAN (R 4.3.1)

fastmap       1.1.1      2023-02-24 [1] CRAN (R 4.3.1)

fs            1.6.3      2023-07-20 [1] CRAN (R 4.3.1)

glue          1.6.2      2022-02-24 [1] CRAN (R 4.3.1)

htmltools     0.5.6      2023-08-10 [1] CRAN (R 4.3.1)

htmlwidgets   1.6.2      2023-03-17 [1] CRAN (R 4.3.1)

httpuv        1.6.11     2023-05-11 [1] CRAN (R 4.3.1)

jquerylib     0.1.4      2021-04-26 [1] CRAN (R 4.3.1)

jsonlite      1.8.7      2023-06-29 [1] CRAN (R 4.3.1)

later         1.3.1      2023-05-02 [1] CRAN (R 4.3.1)

lifecycle     1.0.3      2022-10-07 [1] CRAN (R 4.3.1)

magrittr      2.0.3      2022-03-30 [1] CRAN (R 4.3.1)

memoise       2.0.1      2021-11-26 [1] CRAN (R 4.3.1)

mime          0.12       2021-09-28 [1] CRAN (R 4.3.1)

miniUI        0.1.1.1    2018-05-18 [1] CRAN (R 4.3.1)

pkgbuild      1.4.2      2023-06-26 [1] CRAN (R 4.3.1)

pkgload       1.3.2.1    2023-07-08 [1] CRAN (R 4.3.1)

prettyunits   1.1.1      2020-01-24 [1] CRAN (R 4.3.1)

processx      3.8.2      2023-06-30 [1] CRAN (R 4.3.1)

profvis       0.3.8      2023-05-02 [1] CRAN (R 4.3.1)

promises      1.2.1      2023-08-10 [1] CRAN (R 4.3.1)

ps            1.7.5      2023-04-18 [1] CRAN (R 4.3.1)

purrr         1.0.2      2023-08-10 [1] CRAN (R 4.3.1)

R6            2.5.1      2021-08-19 [1] CRAN (R 4.3.1)

Rcpp          1.0.11     2023-07-06 [1] CRAN (R 4.3.1)

remotes       2.4.2.1    2023-07-18 [1] CRAN (R 4.3.1)

rlang         1.1.1      2023-04-28 [1] CRAN (R 4.3.1)

sass          0.4.7      2023-07-15 [1] CRAN (R 4.3.1)

sessioninfo   1.2.2      2021-12-06 [1] CRAN (R 4.3.1)

shiny         1.7.5      2023-08-12 [1] CRAN (R 4.3.1)

stringi       1.7.12     2023-01-11 [1] CRAN (R 4.3.1)

stringr       1.5.0      2022-12-02 [1] CRAN (R 4.3.1)

urlchecker    1.0.1      2021-11-30 [1] CRAN (R 4.3.1)

usethis       2.2.2      2023-07-06 [1] CRAN (R 4.3.1)

vctrs         0.6.3      2023-06-14 [1] CRAN (R 4.3.1)

xtable        1.8-4      2019-04-21 [1] CRAN (R 4.3.1)


[1] /home/jordan/R/x86_64-pc-linux-gnu-library/4.3

[2] /usr/local/lib/R/site-library

[3] /usr/lib/R/site-library

[4] /usr/lib/R/library


────────────────────────────────────────────────────────────────────────────

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names page_navbar(), sidebar(), and layout_sidebar() but no implementation files or tests. Reproduce the supplied make_page() examples, then trace the page_navbar() and sidebar() entry points while comparing layout_sidebar() behavior. Done means gap = 0 and padding = 0 produce the expected spacing with an open or closed sidebar.

Written by the indexing model from the issue text.

Assessment

Tech stack
r, scss
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.