rstudio / rstudio/bslib

UI of buttons in some bootswatch themes is semi-broken if using bootstrap > 3

Open
#684 4 comments 0 reactions 1 assignee View on GitHub

@gadenbuie is already working on this.

Since Jul 17, 2023.

Dominant language
SCSS
Stars
569
Forks
72
Avg merge
1d 2h
Merged PRs (30d)
5

Description

For example, in the following app, the button's hover state is no different from the main state, which makes the button UI/UX not great.

library(shiny)

ui <- fluidPage(
  theme = bslib::bs_theme(bootswatch = "cerulean"),
  actionButton("test", "test")
)

server <- function(input, output, session) {}

shinyApp(ui, server)

If you use bs_theme(version = 3, bootswatch = "cerulean") then the button regains its hover state.

This is likely because buttons in shiny apply a default class of btn-default, which was available in bootstrap 3 but is no longer available in BS4/5. The closest relative is btn-outline-secondary.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.