Disable page-level fillable containers in `page_*()` functions at small screen heights?
Nobody has claimed this yet.
- Dominant language
- SCSS
- Stars
- 569
- Forks
- 72
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 5
Description
We switch off fillable containers for small screen widths, but page-level fill containers are similarly constrained on small screen heights.
We could disable page-level fillability for small screen heights with a media query like this
@media screen and (max-height: 799px) {
.bslib-page-fill.html-fill-container {
display: block;
}
}
https://github.com/rstudio/bslib/assets/5420529/4709a3b9-fbad-4631-8320-b0af75ec6bf9
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the SCSS or CSS used by the page_*() functions and compare it with the existing handling for small screen widths. Check the behavior of .bslib-page-fill.html-fill-container at heights below 799px, then verify that page-level fillability is disabled at those heights without changing taller layouts.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scss
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100