Review usage of `getCurrentThemeVersion()`
Nobody has claimed this yet.
- Dominant language
- SCSS
- Stars
- 569
- Forks
- 72
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 5
Description
and replace with a bslib-first approach – e.g. bs_current_theme().
https://github.com/rstudio/bslib/blob/7697c730db31bd02ad809c02c46fdc974bfb186b/R/navs-legacy.R#L642
I haven't worked with bs_current_theme() yet, but one detail I'd like to take into account is whether we can use it to generate BS-version-specific markup with minimal side-effects. Ideally we could create, e.g., tabs markup for BS5 and then roll back to defaults without affecting any other calls or global state.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the repository for getCurrentThemeVersion() usages, starting with R/navs-legacy.R at the linked location, and compare them with bs_current_theme(). Check whether Bootstrap-version-specific markup can be generated without affecting later calls or global state. Done means the relevant usages are reviewed or replaced and the behavior remains isolated.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- bootstrap, r
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100