rstudio / rstudio/bslib

Ensure `data-bs-toggle` is present in the BS3 tabset compatibility shims

Open
#492 0 comments 0 reactions 1 assignee View on GitHub

@gadenbuie is already working on this.

Since Mar 10, 2023.

Dominant language
SCSS
Stars
569
Forks
72
Avg merge
1d 2h
Merged PRs (30d)
5

Description

As we noticed in https://github.com/rstudio/flexdashboard/pull/421, newer version of Bootstrap may require the data-bs-toggle in places where data-toggle was previously sufficient. In theory, we could handle this in the tabset compatibility shims by ensuring that data-toggle is copied to data-bs-toggle if the latter isn't present.

https://github.com/rstudio/bslib/blob/9c043a7b88c215b7fca57df4a37a0c601b8b296d/inst/bs3compat/js/bs3compat.js#L27-L31

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.