rstudio / rstudio/bslib

navset_underline() does not propagate fill but navset_card_underline does

Open
#1,312 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Priority: Medium
Dominant language
SCSS
Stars
569
Forks
72
Avg merge
1d 2h
Merged PRs (30d)
5

Description

navset_underline() does not propagate fill to its tab panels inside layout_sidebar(fillable = TRUE)

When you nest a card() inside a navset_underline() inside a layout_sidebar(fillable = TRUE) inside a page_navbar(fillable = TRUE), the card refuses to expand vertically to fill the available space — even though every other container in the chain is set up to fill.

I think the issue is .tabbable and .tab-content have no fill classes.

library(shiny)
library(bslib)

ui <- page_navbar(
  title = "Fill Reprex",
  fillable = TRUE,
  nav_panel(
    "Tab",
    layout_sidebar(
      fillable = TRUE,
      sidebar = sidebar("sidebar content"),
      navset_underline(
        nav_panel(
          "Inner Tab",
          card(
            full_screen = TRUE,
            card_body(
              # This should fill the full height but doesn't
              div(
                style = "background: tomato; height: 100%; width: 100%;",
                "I should fill the card. Card should fill the panel."
              )
            )
          )
        )
      )
    )
  )
)

server <- function(input, output, session) {}

shinyApp(ui, server)



# navset_card_underline works. 

ui <- page_navbar(
  title = "Fill Reprex - Working",
  fillable = TRUE,
  nav_panel(
    "Tab",
    layout_sidebar(
      fillable = TRUE,
      sidebar = sidebar("sidebar content"),
      navset_card_underline(
        full_screen = TRUE,
        nav_panel(
          "Inner Tab",
          div(
            style = "background: tomato; height: 100%; width: 100%;",
            "I fill the card properly."
          )
        )
      )
    )
  )
)

shinyApp(ui, server)
Session Info

 version  R version 4.6.0 (2026-04-24)
 os       macOS Tahoe 26.3.1
 system   aarch64, darwin25.4.0
 ui       RStudio
 language (EN)
 collate  en_US.UTF-8
 ctype    en_US.UTF-8
 tz       America/Los_Angeles
 date     2026-05-13
 rstudio  2026.04.0+526 Globemaster Allium (desktop)
 pandoc   3.9.0.2 @ /opt/homebrew/bin/ (via rmarkdown)
 quarto   1.3.450 @ /usr/local/bin/quarto

abind          1.4-8      2024-09-12 [1] CRAN (R 4.6.0)

assertthat     0.2.1      2019-03-21 [1] CRAN (R 4.6.0)

AzureAuth      1.3.4      2025-12-20 [1] CRAN (R 4.6.0)

AzureGraph     1.3.5      2025-07-31 [1] CRAN (R 4.6.0)

AzureRMR       2.4.5      2025-07-31 [1] CRAN (R 4.6.0)

AzureStor      3.7.1      2025-08-25 [1] CRAN (R 4.6.0)

backports      1.5.1      2026-04-03 [1] CRAN (R 4.6.0)

base64enc      0.1-6      2026-02-02 [1] CRAN (R 4.6.0)

bnlearn        5.1        2025-08-20 [1] CRAN (R 4.6.0)

brio           1.1.5      2024-04-24 [1] CRAN (R 4.6.0)

broom          1.0.12     2026-01-27 [1] CRAN (R 4.6.0)

bsicons        0.1.2      2023-11-04 [1] CRAN (R 4.6.0)

bslib        * 0.10.0     2026-01-26 [1] CRAN (R 4.6.0)

cachem         1.1.0      2024-05-16 [1] CRAN (R 4.6.0)

callr          3.7.6      2024-03-25 [1] CRAN (R 4.6.0)

car            3.1-5      2026-02-03 [1] CRAN (R 4.6.0)

carData        3.0-6      2026-01-30 [1] CRAN (R 4.6.0)

caret          7.0-1      2024-12-10 [1] CRAN (R 4.6.0)

cellranger     1.1.0      2016-07-27 [1] CRAN (R 4.6.0)

checkmate      2.3.4      2026-02-03 [1] CRAN (R 4.6.0)

chromote       0.5.1      2025-04-24 [1] CRAN (R 4.6.0)

class          7.3-23     2025-01-01 [1] CRAN (R 4.6.0)

cli            3.6.6      2026-04-09 [1] CRAN (R 4.6.0)

cluster        2.1.8.2    2026-02-05 [1] CRAN (R 4.6.0)

codetools      0.2-20     2024-03-31 [1] CRAN (R 4.6.0)

colorspace     2.1-2      2025-09-22 [1] CRAN (R 4.6.0)

combinat       0.0-8      2012-10-29 [1] CRAN (R 4.6.0)

commonmark     2.0.0      2025-07-07 [1] CRAN (R 4.6.0)

corrplot       0.95       2024-10-14 [1] CRAN (R 4.6.0)

corrr          0.4.5      2025-08-18 [1] CRAN (R 4.6.0)

crosstalk      1.2.2      2025-08-26 [1] CRAN (R 4.6.0)

curl           7.1.0      2026-04-22 [1] CRAN (R 4.6.0)

data.table     1.18.2.1   2026-01-27 [1] CRAN (R 4.6.0)

DBI            1.3.0      2026-02-25 [1] CRAN (R 4.6.0)

desc           1.4.3      2023-12-10 [1] CRAN (R 4.6.0)

devtools       2.5.2      2026-04-30 [1] CRAN (R 4.6.0)

dichromat      2.0-0.1    2022-05-02 [1] CRAN (R 4.6.0)

digest         0.6.39     2025-11-19 [1] CRAN (R 4.6.0)

dplyr          1.2.1      2026-04-03 [1] CRAN (R 4.6.0)

DT           * 0.34.0     2025-09-02 [1] CRAN (R 4.6.0)

e1071          1.7-17     2025-12-18 [1] CRAN (R 4.6.0)

ellipsis       0.3.3      2026-04-04 [1] CRAN (R 4.6.0)

entropy        1.3.2      2025-04-07 [1] CRAN (R 4.6.0)

evaluate       1.0.5      2025-08-27 [1] CRAN (R 4.6.0)

farver         2.1.2      2024-05-13 [1] CRAN (R 4.6.0)

fastmap        1.2.0      2024-05-15 [1] CRAN (R 4.6.0)

fontawesome    0.5.3      2024-11-16 [1] CRAN (R 4.6.0)

forcats        1.0.1      2025-09-25 [1] CRAN (R 4.6.0)

foreach        1.5.2      2022-02-02 [1] CRAN (R 4.6.0)

foreign        0.8-91     2026-01-29 [1] CRAN (R 4.6.0)

Formula        1.2-5      2023-02-24 [1] CRAN (R 4.6.0)

fs             2.1.0      2026-04-18 [1] CRAN (R 4.6.0)

furrr          0.4.0      2026-03-31 [1] CRAN (R 4.6.0)

future         1.70.0     2026-03-14 [1] CRAN (R 4.6.0)

future.apply   1.20.2     2026-02-20 [1] CRAN (R 4.6.0)

generics       0.1.4      2025-05-09 [1] CRAN (R 4.6.0)

ggplot2        4.0.3      2026-04-22 [1] CRAN (R 4.6.0)

globals        0.19.1     2026-03-13 [1] CRAN (R 4.6.0)

glue           1.8.1      2026-04-17 [1] CRAN (R 4.6.0)

gower          1.0.2      2024-12-17 [1] CRAN (R 4.6.0)

gRain          1.4.6      2026-03-02 [1] CRAN (R 4.6.0)

gRbase       * 2.0.3      2024-10-22 [1] CRAN (R 4.6.0)

gridExtra      2.3        2017-09-09 [1] CRAN (R 4.6.0)

gsubfn         0.7        2018-03-16 [1] CRAN (R 4.6.0)

gtable         0.3.6      2024-10-25 [1] CRAN (R 4.6.0)

hardhat        1.4.3      2026-04-04 [1] CRAN (R 4.6.0)

haven          2.5.5      2025-05-30 [1] CRAN (R 4.6.0)

highcharter    0.9.5      2026-04-22 [1] CRAN (R 4.6.0)

highr          0.12       2026-03-06 [1] CRAN (R 4.6.0)

Hmisc          5.2-5      2026-01-09 [1] CRAN (R 4.6.0)

hms            1.1.4      2025-10-17 [1] CRAN (R 4.6.0)

htmlTable      2.5.0      2026-04-22 [1] CRAN (R 4.6.0)

htmltools    * 0.5.9      2025-12-04 [1] CRAN (R 4.6.0)

htmlwidgets    1.6.4      2023-12-06 [1] CRAN (R 4.6.0)

httpuv         1.6.17     2026-03-18 [1] CRAN (R 4.6.0)

httr           1.4.8      2026-02-13 [1] CRAN (R 4.6.0)

httr2          1.2.2      2025-12-08 [1] CRAN (R 4.6.0)

igraph         2.3.1      2026-05-04 [1] CRAN (R 4.6.0)

ipred          0.9-15     2024-07-18 [1] CRAN (R 4.6.0)

iterators      1.0.14     2022-02-05 [1] CRAN (R 4.6.0)

janitor        2.2.1      2024-12-22 [1] CRAN (R 4.6.0)

jquerylib      0.1.4      2021-04-26 [1] CRAN (R 4.6.0)

jsonlite       2.0.0      2025-03-27 [1] CRAN (R 4.6.0)

klaR           1.7-4      2026-02-23 [1] CRAN (R 4.6.0)

knitr          1.51       2025-12-20 [1] CRAN (R 4.6.0)

labelled       2.16.0     2025-10-22 [1] CRAN (R 4.6.0)

later          1.4.8      2026-03-05 [1] CRAN (R 4.6.0)

lattice        0.22-9     2026-02-09 [1] CRAN (R 4.6.0)

lava           1.9.0      2026-04-05 [1] CRAN (R 4.6.0)

lazyeval       0.2.3      2026-04-04 [1] CRAN (R 4.6.0)

lifecycle      1.0.5      2026-01-08 [1] CRAN (R 4.6.0)

listenv        0.10.1     2026-03-10 [1] CRAN (R 4.6.0)

lubridate      1.9.5      2026-02-04 [1] CRAN (R 4.6.0)

magrittr     * 2.0.5      2026-04-04 [1] CRAN (R 4.6.0)

MASS           7.3-65     2025-02-28 [1] CRAN (R 4.6.0)

Matrix         1.7-5      2026-03-21 [1] CRAN (R 4.6.0)

MatrixModels   0.5-4      2025-03-26 [1] CRAN (R 4.6.0)

matrixStats    1.5.0      2025-01-07 [1] CRAN (R 4.6.0)

memoise        2.0.1      2021-11-26 [1] CRAN (R 4.6.0)

mime           0.13       2025-03-17 [1] CRAN (R 4.6.0)

miniUI         0.1.2      2025-04-17 [1] CRAN (R 4.6.0)

mnormt         2.1.2      2026-01-27 [1] CRAN (R 4.6.0)

ModelMetrics   1.2.2.2    2020-03-17 [1] CRAN (R 4.6.0)

multcomp       1.4-30     2026-03-09 [1] CRAN (R 4.6.0)

mvtnorm        1.3-7      2026-04-15 [1] CRAN (R 4.6.0)

nlme           3.1-169    2026-03-27 [1] CRAN (R 4.6.0)

nnet           7.3-20     2025-01-01 [1] CRAN (R 4.6.0)

openxlsx       4.2.8.1    2025-10-31 [1] CRAN (R 4.6.0)

openxlsx2      1.26       2026-04-17 [1] CRAN (R 4.6.0)

otel           0.2.0      2025-08-29 [1] CRAN (R 4.6.0)

pak            0.9.5      2026-04-27 [1] CRAN (R 4.6.0)

parallelly     1.47.0     2026-04-17 [1] CRAN (R 4.6.0)

pillar         1.11.1     2025-09-17 [1] CRAN (R 4.6.0)

pkgbuild       1.4.8      2025-05-26 [1] CRAN (R 4.6.0)

pkgconfig      2.0.3      2019-09-22 [1] CRAN (R 4.6.0)

pkgload        1.5.2      2026-04-22 [1] CRAN (R 4.6.0)

plotly         4.12.0     2026-01-24 [1] CRAN (R 4.6.0)

plyr           1.8.9      2023-10-02 [1] CRAN (R 4.6.0)

polspline      1.1.25     2024-05-10 [1] CRAN (R 4.6.0)

pROC           1.19.0.1   2025-07-31 [1] CRAN (R 4.6.0)

processx       3.9.0      2026-04-22 [1] CRAN (R 4.6.0)

prodlim        2026.03.11 2026-03-11 [1] CRAN (R 4.6.0)

progressr      0.19.0     2026-03-31 [1] CRAN (R 4.6.0)

promises       1.5.0      2025-11-01 [1] CRAN (R 4.6.0)

proto          1.0.0      2016-10-29 [1] CRAN (R 4.6.0)

proxy          0.4-29     2025-12-29 [1] CRAN (R 4.6.0)

ps             1.9.3      2026-04-20 [1] CRAN (R 4.6.0)

psych          2.6.3      2026-03-25 [1] CRAN (R 4.6.0)

purrr          1.2.2      2026-04-10 [1] CRAN (R 4.6.0)

quantmod       0.4.28     2025-06-19 [1] CRAN (R 4.6.0)

quantreg       6.1        2025-03-10 [1] CRAN (R 4.6.0)

questionr      0.8.2      2026-01-21 [1] CRAN (R 4.6.0)

R6             2.6.1      2025-02-15 [1] CRAN (R 4.6.0)

rappdirs       0.3.4      2026-01-17 [1] CRAN (R 4.6.0)

RColorBrewer   1.1-3      2022-04-03 [1] CRAN (R 4.6.0)

Rcpp           1.1.1-1.1  2026-04-24 [1] CRAN (R 4.6.0)

readxl         1.4.5      2025-03-07 [1] CRAN (R 4.6.0)

recipes        1.3.2      2026-04-02 [1] CRAN (R 4.6.0)

repr           1.1.7      2024-03-22 [1] CRAN (R 4.6.0)

reshape2       1.4.5      2025-11-12 [1] CRAN (R 4.6.0)

rlang          1.2.0      2026-04-06 [1] CRAN (R 4.6.0)

rlist          0.4.6.2    2021-09-03 [1] CRAN (R 4.6.0)

rmarkdown      2.31       2026-03-26 [1] CRAN (R 4.6.0)

rms            8.1-1      2026-02-18 [1] CRAN (R 4.6.0)

roxygen2       8.0.0      2026-05-01 [1] CRAN (R 4.6.0)

rpart          4.1.27     2026-03-27 [1] CRAN (R 4.6.0)

rprojroot      2.1.1      2025-08-26 [1] CRAN (R 4.6.0)

rstudioapi     0.18.0     2026-01-16 [1] CRAN (R 4.6.0)

rvest          1.0.5      2025-08-29 [1] CRAN (R 4.6.0)

S7             0.2.2      2026-04-22 [1] CRAN (R 4.6.0)

sandwich       3.1-1      2024-09-15 [1] CRAN (R 4.6.0)

sass           0.4.10     2025-04-11 [1] CRAN (R 4.6.0)

scales         1.4.0      2025-04-24 [1] CRAN (R 4.6.0)

sessioninfo    1.2.3      2025-02-05 [1] CRAN (R 4.6.0)

shiny        * 1.13.0     2026-02-20 [1] CRAN (R 4.6.0)

skimr          2.2.2      2026-01-10 [1] CRAN (R 4.6.0)

snakecase      0.11.1     2023-08-27 [1] CRAN (R 4.6.0)

SparseM        1.84-2     2024-07-17 [1] CRAN (R 4.6.0)

stringi        1.8.7      2025-03-27 [1] CRAN (R 4.6.0)

stringr        1.6.0      2025-11-04 [1] CRAN (R 4.6.0)

survival       3.8-6      2026-01-16 [1] CRAN (R 4.6.0)

testthat       3.3.2      2026-01-11 [1] CRAN (R 4.6.0)

TH.data        1.1-5      2025-11-17 [1] CRAN (R 4.6.0)

tibble         3.3.1      2026-01-11 [1] CRAN (R 4.6.0)

tictoc         1.2.1      2024-03-18 [1] CRAN (R 4.6.0)

tidyr          1.3.2      2025-12-19 [1] CRAN (R 4.6.0)

tidyselect     1.2.1      2024-03-11 [1] CRAN (R 4.6.0)

timechange     0.4.0      2026-01-29 [1] CRAN (R 4.6.0)

timeDate       4052.112   2026-01-28 [1] CRAN (R 4.6.0)

TTR            0.24.4     2023-11-28 [1] CRAN (R 4.6.0)

usethis        3.2.1      2025-09-06 [1] CRAN (R 4.6.0)

uuid           1.2-2      2026-01-23 [1] CRAN (R 4.6.0)

vctrs          0.7.3      2026-04-11 [1] CRAN (R 4.6.0)

viridisLite    0.4.3      2026-02-04 [1] CRAN (R 4.6.0)

visNetwork     2.1.4      2025-09-04 [1] CRAN (R 4.6.0)

webshot2       0.1.2      2025-04-23 [1] CRAN (R 4.6.0)

websocket      1.4.4      2025-04-10 [1] CRAN (R 4.6.0)

withr          3.0.2      2024-10-28 [1] CRAN (R 4.6.0)

P work         * 0.1.0      2026-05-12 [?] Github (tsolloway/work@e6c7667)

xfun           0.57       2026-03-20 [1] CRAN (R 4.6.0)

xml2           1.5.2      2026-01-17 [1] CRAN (R 4.6.0)

xtable         1.8-8      2026-02-22 [1] CRAN (R 4.6.0)

xts            0.14.2     2026-02-28 [1] CRAN (R 4.6.0)

yaml           2.3.12     2025-12-10 [1] CRAN (R 4.6.0)

zip            2.3.3      2025-05-13 [1] CRAN (R 4.6.0)

zoo            1.8-15     2025-12-15 [1] CRAN (R 4.6.0)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the supplied Shiny bslib reprex and inspecting the generated markup and classes around .tabbable and .tab-content. Compare it with navset_card_underline and trace the fill behavior in the relevant SCSS; done means navset_underline's tab panels fill the available height in the nested fillable layout without regressing the card variant.

Written by the indexing model from the issue text.

Assessment

Tech stack
bootstrap, scss
Domain
frontend, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.