rstudio / rstudio/bslib

input$my_card_full_screen should not exist for cards that don't have full_screen=TRUE

Open
#1,305 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Priority: Low
Dominant language
SCSS
Stars
569
Forks
72
Avg merge
1d 2h
Merged PRs (30d)
5

Description

The default for cards is to have full_screen=FALSE. Currently, any card that has an ID will automatically cause an additional input to be created even though it's meaningless. This is mostly frustrating for dealing with bookmarks, where inputs need to be explicitly removed. It would make sense to only create this input if the card actually supports full screen.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue does not name a file or test. Start by locating the card implementation and the code that creates input$my_card_full_screen; verify that cards with full_screen=FALSE no longer create that input, while full-screen cards still do.

Written by the indexing model from the issue text.

Assessment

Tech stack
bootstrap
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.