rstudio / rstudio/bslib

Two tests are failing - no idea why

Open
#1,197 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
SCSS
Stars
569
Forks
72
Avg merge
1d 2h
Merged PRs (30d)
5

Description

Describe the problem

The Debian packaged version of bslib shows two errors of the test suite. We are running the test suite with this script. This leads to

══ Failed tests ════════════════════════════════════════════════════════════════
── Failure ('test-theme-base-colors.R:368:3'): theme-color('default') works as expected ──
gsub("\\s+|\\n", "", as.character(expect)) (`actual`) not identical to gsub("\\s+|\\n", "", as.character(actual)) (`expected`).

`actual`:   ""      
`expected`: ".foo{color:#dee2e6;}"
Backtrace:
    ▆
 1. └─bslib:::expect_css(css, ".foo{color:#dee2e6;}") at test-theme-base-colors.R:368:3
 2.   └─testthat::expect_identical(...) at tests/testthat/helper-css.R:4:3
── Failure ('test-theme-base-colors.R:374:3'): theme-color('default') works as expected ──
gsub("\\s+|\\n", "", as.character(expect)) (`actual`) not identical to gsub("\\s+|\\n", "", as.character(actual)) (`expected`).

`actual`:   ""
`expected`: ".foo{color:#FF0000;}"
Backtrace:
    ▆
 1. └─bslib:::expect_css(css, ".foo{color:#FF0000;}") at test-theme-base-colors.R:374:3
 2.   └─testthat::expect_identical(...) at tests/testthat/helper-css.R:4:3

[ FAIL 2 | WARN 0 | SKIP 32 | PASS 517 ]
Session Info

─ Session info ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
 setting  value
 version  R version 4.5.0 (2025-04-11)
 os       Debian GNU/Linux trixie/sid
 system   x86_64, linux-gnu
 ui       X11
 language (EN)
 collate  de_DE.UTF-8
 ctype    de_DE.UTF-8
 tz       Europe/Berlin
 date     2025-04-15
 pandoc   3.1.11.1 @ /usr/bin/pandoc
 quarto   NA

─ Packages ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
package * version date (UTC) lib source
cachem 1.1.0 2024-05-16 [2] CRAN (R 4.4.1)
cli 3.6.4 2025-02-13 [2] CRAN (R 4.4.2)
devtools 2.4.5 2022-10-11 [2] CRAN (R 4.2.1)
digest 0.6.37 2024-08-19 [2] CRAN (R 4.4.1)
ellipsis 0.3.2 2021-04-29 [2] CRAN (R 4.1.1)
fastmap 1.2.0 2024-05-15 [2] CRAN (R 4.4.1)
fs 1.6.5 2024-10-30 [2] CRAN (R 4.4.2)
glue 1.8.0 2024-09-30 [2] CRAN (R 4.4.2)
htmltools 0.5.8.1 2024-04-04 [2] CRAN (R 4.4.0)
htmlwidgets 1.6.4 2023-12-06 [2] CRAN (R 4.3.2)
httpuv 1.6.15 2024-03-26 [2] CRAN (R 4.3.3)
later 1.4.1 2024-11-27 [2] CRAN (R 4.4.2)
lifecycle 1.0.4 2023-11-07 [2] CRAN (R 4.3.2)
magrittr 2.0.3 2022-03-30 [2] CRAN (R 4.2.0)
memoise 2.0.1 2021-11-26 [2] CRAN (R 4.1.2)
mime 0.12 2021-09-28 [2] CRAN (R 4.3.3)
miniUI 0.1.1.1 2018-05-18 [2] CRAN (R 4.0.0)
pkgbuild 1.4.6 2025-01-16 [2] CRAN (R 4.4.2)
pkgload 1.4.0 2024-06-28 [2] CRAN (R 4.4.1)
profvis 0.4.0 2024-09-20 [2] CRAN (R 4.4.1)
promises 1.3.2 2024-11-28 [2] CRAN (R 4.4.2)
purrr 1.0.4 2025-02-05 [2] CRAN (R 4.4.2)
R6 2.6.1 2025-02-15 [2] CRAN (R 4.4.2)
Rcpp 1.0.14 2025-01-12 [2] CRAN (R 4.4.2)
remotes 2.5.0 2024-03-17 [2] CRAN (R 4.4.1)
rlang 1.1.5 2025-01-17 [2] CRAN (R 4.4.2)
sessioninfo 1.2.3 2025-02-05 [2] CRAN (R 4.4.2)
shiny 1.10.0 2024-12-14 [2] CRAN (R 4.4.2)
urlchecker 1.0.1 2021-11-30 [2] CRAN (R 4.2.1)
usethis 3.1.0 2024-11-26 [2] CRAN (R 4.4.2)
vctrs 0.6.5 2023-12-01 [2] CRAN (R 4.3.2)
xtable 1.8-4 2019-04-21 [2] CRAN (R 4.0.0)

[1] /usr/local/lib/R/site-library
[2] /usr/lib/R/site-library
[3] /usr/lib/R/library

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the Debian test run from debian/tests/run-unit-test and inspect the failures in test-theme-base-colors.R around lines 368 and 374. Read tests/testthat/helper-css.R to trace why the generated CSS is empty; done means identifying the Debian-specific cause and making both theme-color expectations pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
bootstrap, debian, r, sass
Domain
frontend, testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.