rstudio / rstudio/bslib

the x button in popover is not visible when theme = "flatly"

Open
#1,152 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
SCSS
Stars
569
Forks
72
Avg merge
1d 2h
Merged PRs (30d)
5

Description

Describe the problem

The x button to close the popover is not very visible with theme = "flatly". It looks fine for the default shiny theme.

page_fixed(theme = bs_theme(version = 5, bootswatch = "flatly"), popover("Text", "new text", title = "popover"))

See screenshot:

Image

Expected behavior

As an example, this works well:

page_fixed(theme = bs_theme(version = 5), popover("Text", "new text", title = "popover"))

Image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue through page_fixed(), bs_theme(version = 5, bootswatch = "flatly"), and popover(), then compare the close button with the default shiny theme. Done means the x button is clearly visible with flatly while retaining the expected appearance in the default theme; the payload names no files or tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
bootstrap, r, scss
Domain
design, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.