Should `theme` argument in `page_*()` functions accept a string?
Nobody has claimed this yet.
- Dominant language
- SCSS
- Stars
- 569
- Forks
- 72
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 5
Description
In shiny's page functions, the theme argument can accept either a bs_theme() object or a path to a CSS file.
In bslib's page functions, the documentation says that the only acceptable value is a bs_theme() object. However, it seems that providing a string path to a CSS file also works. Should this be accepted or no? If yes, it should be documented. If no, an error should get thrown.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the bslib page_* functions and their theme argument documentation, then verify whether a CSS path is currently accepted. Done means the behavior is intentionally chosen and either documented for users or rejected consistently with an error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scss
- Domain
- documentation, web-dev
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100