Null value returned from AddList
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 20.2k
- Forks
- 1.7k
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 17
Description
I don't know why yet but this get call here, https://github.com/rrweb-io/rrweb/blob/master/src/record/mutation.ts#L354, can return null.
I had to add a null check in the for loop.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/record/mutation.ts at line 354 and inspect the AddList call together with the surrounding loop. Trace when the get call returns null, then verify the mutation path no longer produces an unhandled null; the report is complete when the cause and expected behavior are established.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100