Audit outparam syscalls to ensure all use scratch
Open
Nobody has claimed this yet.
goodfirstbug
- Dominant language
- C++
- Stars
- 10.7k
- Forks
- 662
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 2
Description
I've fallen into the trap several times of thinking that only may-block syscalls need scratch, but in fact any syscall with outparams needs to use scratch. We should ensure that this is the case. On the fence about this for 1.0; lean towards no because we're not seeing problems in the field (or #876 might be this, but I doubt it).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named. Start by locating the syscall handling and auditing every syscall with outparams, not only those that may block, to determine where scratch is required. Done means the audit is complete and all applicable syscalls consistently use scratch, with relevant tests or checks passing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, linux
- Domain
- devtools, operating-systems
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100