rr-debugger / rr-debugger/rr

Don't disable/close/open/enable rbc for every event

Open
#803 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
10.7k
Forks
662
Avg merge
2d 3h
Merged PRs (30d)
2

Description

Followup to #279:

What we should do instead is use absolute counter values and never close/ioctl these counters. Our time-slice interrupt guarantees that a counter can't overflow past its initial value during one event, and anyway it would take ~50,000 years of 100% CPU load for a counter to even overflow in the first place.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading follow-up #279 and locating the event code that disables, closes, opens, or enables rbc counters. Verify the time-slice interrupt and absolute-counter assumptions; done means events no longer perform those operations while counter behavior remains correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, linux
Domain
devtools, operating-systems
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.