`--serve-files` option should be read from trace
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.7k
- Forks
- 662
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 2
Description
Currently --serve-files can only read files that were copied into the trace dir. This makes sense because it was intended to serve various executables and shared libraries to gdb. However, I don't see any reason why we couldn't also write out files that were copied into the trace. Currently in this case you get:
(rr) remote get /tmp/jl_XrKiUH/sys.o.a input2.o.a
Remote I/O error: Invalid argument
Since I wrote this feature this is probably a TODO for myself.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the --serve-files implementation and the remote get handling described in the issue. Trace how copied files are exposed from the trace directory, then make remote get work for those files as well and verify that the shown input2.o.a operation succeeds.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, linux
- Domain
- devtools
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100