Nested signal handlers: assertion failure
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.7k
- Forks
- 662
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 2
Description
While debugging a separate issue, we ran into an assertion failure
hello[FATAL src/RecordTask.cc:1840:pop_event()]
(task 136189 (rec:136189) at time 254)
-> Assertion `pending_events.back().type() == expected_type' failed to hold.
Test case:
#include <signal.h>
#include <stdlib.h>
#include <unistd.h>
static void SEGV_handler(__attribute__((unused)) int sig,
__attribute__((unused)) siginfo_t* si,
__attribute__((unused)) void* context) {
alarm(1);
pause();
}
static void alarm_handler(__attribute__((unused)) int sig,
__attribute__((unused)) siginfo_t* si,
__attribute__((unused)) void* context) {
write(1, "hello", 5);
}
int main() {
int size = 8 * 0x4000;
void * stk_c = malloc(size);
stack_t stk = {stk_c, 0, size};
sigaltstack(&stk, 0);
struct sigaction sa1, sa2;
sa1.sa_sigaction = SEGV_handler;
sa1.sa_flags = SA_SIGINFO | SA_ONSTACK;
sigemptyset(&sa1.sa_mask);
sigaction(SIGSEGV, &sa1, NULL);
sa2.sa_sigaction = alarm_handler;
sa2.sa_flags = SA_SIGINFO | SA_ONSTACK;
sigemptyset(&sa2.sa_mask);
sigaction(SIGALRM, &sa2, NULL);
raise(SIGSEGV);
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Use the supplied C reproducer with nested SIGSEGV and SIGALRM handlers, then inspect src/RecordTask.cc around pop_event() at line 1840. Trace how nested signal events are recorded and consumed, and determine what behavior should replace the assertion. Done means the reproducer no longer triggers the reported assertion without regressing signal handling.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, cpp, linux
- Domain
- devtools, operating-systems
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100