rr-debugger / rr-debugger/rr

rr record hangs on DCHECK failures on Chromium's blink_unittests

Open
#3,382 6 comments 0 reactions 1 assignee View on GitHub

@rocallahan is already working on this.

Since Oct 13, 2022.

Dominant language
C++
Stars
10.7k
Forks
662
Avg merge
2d 3h
Merged PRs (30d)
2

Description

Chromium has a binary blink_unittests that runs a number of tests for Blink with gtest, and rr record hangs whenever it hits an assertion failure (with DCHECK). The log showing the cause of the assertion failure is printed, but the hang seems to happen before the stack trace can be printed.

To reproduce, try adding a dummy test to some of the unit test files under third_party/blink. For example, with third_party/blink/renderer/core/layout/layout_table_test.cc, add the following:

TEST_F(LayoutTableTest, DummyTestForRr) {
  DCHECK(false);
}

Then compile with autoninja -C out/Default blink_tests and record with rr record ./out/Default/blink_unittests --gtest_filter="LayoutTableTest.DummyTestForRr".

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.