Building rr using external blake2 and brotli
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.7k
- Forks
- 662
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 2
Description
Fedora packaging guidelines discourage the use of bundled packages for building rpms.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling
Fedora has system copies of blake2 (libb2) and brotli available. Is there some way to configure rr to use the system versions of those packages?
It looks like some patching is needed as there is a hard coded include to the third-party directory:
$ grep -r third-party
PackCommand.cc:#include "../third-party/blake2/blake2.h"
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the build configuration and PackCommand.cc, including the hard-coded ../third-party/blake2/blake2.h include. Check how rr currently finds blake2 and brotli, then determine the Fedora system-library integration points. Done means rr can build against Fedora's system copies without relying on bundled blake2 or brotli.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- build-system
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100