rr-debugger / rr-debugger/rr

Release mode means no asserts

Open
#1,835 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
10.7k
Forks
662
Avg merge
2d 3h
Merged PRs (30d)
2

Description

Hi,
I just noticed in release notes for 4.4.0 this bit:

Compile releases with CMAKE_BUILD_TYPE=Release for improved performance.

I just wanted to check you are aware it means -O3 -D_NDEBUG which will disable all asserts and perhaps other checks in the code, which in the past have been reported and fixed. CMake also has RelWithDebInfo build type, which is -O2 -g -DDEBUG and may perhaps be better suited.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the 4.4.0 release note and the project's CMake build-type configuration, focusing on the assertions and checks affected by Release builds. Done should mean that the project has a decided, documented release-build configuration or guidance that addresses whether assertions and debugging information should remain available.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp
Domain
build-system, release
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.