Fix signal handler
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.7k
- Forks
- 662
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 2
Description
I guess that a different program design will be needed for your function "handle_SIGTERM".
- The variable "term_request" should use the data type "sig_atomic_t" (instead of "bool").
- The function "LOG" does not belong to the list of async-signal-safe functions.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/RecordCommand.cc at handle_SIGTERM and term_request, then inspect LOG in src/log.h. Check the signal-handler constraints identified in the issue and the surrounding termination flow. Done means the handler uses an appropriate signal-safe design and no longer invokes unsafe logging from the handler, with relevant tests or validation run.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 32/100